[
https://issues.apache.org/jira/browse/DERBY-2191?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12464306
]
Dyre Tjeldvoll commented on DERBY-2191:
---------------------------------------
I can confirm that the following methods aren't used and can be removed:
public FormatableBitSet(byte[] newValue, int numBits)
public FormatableBitSet concatenate(FormatableBitSet other)
private static byte hexCharToByte(char hexChar)
private static char[] decodeArray = {'0', '1', '2', '3', '4', '5', '6', '7',
'8', '9', 'a',
'b', 'c', 'd', 'e', 'f'};
public void readExternalFromArray(ArrayInputStream in) throws IOException
I plan to submit a patch for this when the JUnit test has been committed (since
removing these method will require changes to the test)
> Cleanup of FormatableBitSet
> ---------------------------
>
> Key: DERBY-2191
> URL: https://issues.apache.org/jira/browse/DERBY-2191
> Project: Derby
> Issue Type: Improvement
> Components: Miscellaneous
> Affects Versions: 10.2.1.6
> Reporter: Dyre Tjeldvoll
> Assigned To: Dyre Tjeldvoll
> Priority: Trivial
> Fix For: 10.3.0.0
>
> Attachments: deadcode.v1.diff, deadcode.v2.diff, fbstst.v1.diff,
> fbstst.v1.stat, FormatableBitSetTest.java
>
>
> The implementation of FormatableBitSet could be streamlined. Dead code can be
> removed and the implementation of some methods can be simplified.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
https://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
