[
https://issues.apache.org/jira/browse/DERBY-3149?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12542213
]
Kristian Waagan commented on DERBY-3149:
----------------------------------------
Thank for looking at the second patch Dag.
I'll remove the message stating that the build is complete.
Not quite convinced about the debug-comment though. I don't see any reason not
to compile with debug=true when it comes to test code, if something fails
(expected or unexpected) in a test I would like to get as much information as
possible. When I do a find-grep for debug="true", I get 44 matches. All except
one are in the java/testing directory.
I heartily agree with you on expanding ${debug} in non-testing code, but I need
more convincing to change it in the targets compiling the testing code :)
> Add ant targets for building and running the package private tests against
> the classes directories
> --------------------------------------------------------------------------------------------------
>
> Key: DERBY-3149
> URL: https://issues.apache.org/jira/browse/DERBY-3149
> Project: Derby
> Issue Type: Sub-task
> Components: Build tools, Test
> Affects Versions: 10.4.0.0
> Reporter: Kristian Waagan
> Assignee: Kristian Waagan
> Priority: Minor
> Fix For: 10.4.0.0
>
> Attachments: derby-3149-1a.diff, derby-3149-1a.stat,
> derby-3149-1b.diff, derby-3149-2a-conditional_compilation_fix.diff
>
>
> Create ant targets in build.xml to compile and run the package private tests.
> The first step will be to run the tests against the classes directories.
> Implementing a solution that runs against jars is not technically difficult,
> it just brings a host of decisions to be taken... Maybe even more important,
> does running against the jars add any value?
> The compile will be included in the 'all' target to test the implementation.
> Feel free to post your concerns if you think building the package private
> tests should be a manual action only.
> The tests will also be run as part of junit-all / junitreport.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
