[
https://issues.apache.org/jira/browse/DERBY-3149?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12542404
]
Dag H. Wanvik commented on DERBY-3149:
--------------------------------------
Ok, I was not aware that setting debug always true is a common pattern in the
testing code.
If that's the case, I agree its good. I just seemed to remember once having to
go through hoops
to get the debug variable set for some testing code which had not inherited the
debug flag correctly
on the basis of sanity=sane, so I assumed it used the pattern common elsewhere
in the code
(outside testing). Lesson: don't assume, check first ;)
> Add ant targets for building and running the package private tests against
> the classes directories
> --------------------------------------------------------------------------------------------------
>
> Key: DERBY-3149
> URL: https://issues.apache.org/jira/browse/DERBY-3149
> Project: Derby
> Issue Type: Sub-task
> Components: Build tools, Test
> Affects Versions: 10.4.0.0
> Reporter: Kristian Waagan
> Assignee: Kristian Waagan
> Priority: Minor
> Fix For: 10.4.0.0
>
> Attachments: derby-3149-1a.diff, derby-3149-1a.stat,
> derby-3149-1b.diff, derby-3149-2a-conditional_compilation_fix.diff,
> derby-3149-2b-conditional_compilation_fix.diff
>
>
> Create ant targets in build.xml to compile and run the package private tests.
> The first step will be to run the tests against the classes directories.
> Implementing a solution that runs against jars is not technically difficult,
> it just brings a host of decisions to be taken... Maybe even more important,
> does running against the jars add any value?
> The compile will be included in the 'all' target to test the implementation.
> Feel free to post your concerns if you think building the package private
> tests should be a manual action only.
> The tests will also be run as part of junit-all / junitreport.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
