[ 
https://issues.apache.org/jira/browse/DERBY-1387?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12562655#action_12562655
 ] 

Rick Hillegas commented on DERBY-1387:
--------------------------------------

Hi John,

It sounds as though you are on a good track here. It's hard to say without 
seeing the revised patch. Some more defensive code may be needed, however. I am 
worried that the following may happen:

1) The customer runs on jdk1.4 without the extra JMX jar file but nevertheless 
sets derby.system.jmx=true.

or

2) Same as (1) but the extra JMX jar file IS included on the classpath.

In these cases I'm worried that we will see boot errors when the monitor tries 
to bring up the ManagementService. In case (1) I'm worried that  
BasicManagementService will fail to boot because the JMX references can't be 
resolved. In case (2) the BasicManagementService, compiled into Java 5 byte 
code, will fail to load on jdk1.4.

To handle (1), you may want to instrument the monitor with defensive code so 
that it won't boot the ManagementService unless the MBeanServer appears on the 
classpath--and emit an easy-to-understand diagnostic. To handle (2) you may 
want to do one of the following:

a) Instrument the monitor so that it only boots ManagementService if the VM is 
at level Java 5 or higher (otherwise emit a friendly diagnostic)

or

b) Change the mbeans build target in impl/services/build.xml so that the mbeans 
package is compiled into 1.4 byte code.

> Add JMX extensions to Derby
> ---------------------------
>
>                 Key: DERBY-1387
>                 URL: https://issues.apache.org/jira/browse/DERBY-1387
>             Project: Derby
>          Issue Type: New Feature
>          Components: Services
>            Reporter: Sanket Sharma
>            Assignee: John H. Embretsen
>         Attachments: DERBY-1387-1.diff, DERBY-1387-1.stat, DERBY-1387-2.diff, 
> DERBY-1387-2.stat, DERBY-1387-3.diff, DERBY-1387-3.stat, DERBY-1387-4.diff, 
> DERBY-1387-4.stat, DERBY-1387-5.diff, DERBY-1387-5.stat, DERBY-1387-6.zip, 
> DERBY-1387-7.zip, DERBY-1387-8.zip, derbyjmx.patch, jmx.diff, jmx.stat, 
> jmxFuncspec.html, Requirements for JMX Updated.html, Requirements for 
> JMX.html, Requirements for JMX.zip
>
>
> This is a draft requirement specification for adding monitoring and 
> management extensions to Apache Derby using JMX. The requirements document 
> has been uploaded on JIRA as well as the Derby Wiki page at 
> http://wiki.apache.org/db-derby/_Requirement_Specifications_for_Monitoring_%26_Management_Extensions_using_JMX
> Developers and Users are requested to please look at the document (feature 
> list in particular) and add their own rating to features by adding a coloumn 
> to the table.
> Comments are welcome.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply via email to