[ 
https://issues.apache.org/jira/browse/DERBY-1387?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12565120#action_12565120
 ] 

John H. Embretsen commented on DERBY-1387:
------------------------------------------

Strange - I'm not able to see what you were seeing, Dan. Here's some grep 
results from the patch file DERBY-1387-9.diff that I just downloaded from Jira 
onto a machine which has not seen it before:

$grep -c "Index.*Version.java" DERBY-1387-9.diff
1

$grep "Version.java" DERBY-1387-9.diff
Index: java/engine/org/apache/derby/impl/services/mbeans/Version.java
--- java/engine/org/apache/derby/impl/services/mbeans/Version.java      
(revision 0)
+++ java/engine/org/apache/derby/impl/services/mbeans/Version.java      
(revision 0)

$grep "class Version" DERBY-1387-9.diff
+public class Version implements VersionMBean {

With Standard MBeans (which is the type of MBeans included in the patch), the 
requirement is that there is an interface which name ends with "MBean" and a 
class implementing that class, with the same name but without the "MBean" 
ending. As far as I know there may be other rules for other types of MBeans 
(Dynamic, Model, ...). As far as I can see the patch fulfills this requirement, 
but if I'm misunderstanding something, I need some help to understand exactly 
what.

> Add JMX extensions to Derby
> ---------------------------
>
>                 Key: DERBY-1387
>                 URL: https://issues.apache.org/jira/browse/DERBY-1387
>             Project: Derby
>          Issue Type: New Feature
>          Components: Services
>            Reporter: Sanket Sharma
>            Assignee: John H. Embretsen
>         Attachments: DERBY-1387-1.diff, DERBY-1387-1.stat, DERBY-1387-2.diff, 
> DERBY-1387-2.stat, DERBY-1387-3.diff, DERBY-1387-3.stat, DERBY-1387-4.diff, 
> DERBY-1387-4.stat, DERBY-1387-5.diff, DERBY-1387-5.stat, DERBY-1387-6.zip, 
> DERBY-1387-7.zip, DERBY-1387-8.zip, DERBY-1387-9.diff, DERBY-1387-9.stat, 
> derbyjmx.patch, jmx.diff, jmx.stat, jmxFuncspec.html, jmxFuncspec.html, 
> Requirements for JMX Updated.html, Requirements for JMX.html, Requirements 
> for JMX.zip
>
>
> This is a draft requirement specification for adding monitoring and 
> management extensions to Apache Derby using JMX. The requirements document 
> has been uploaded on JIRA as well as the Derby Wiki page at 
> http://wiki.apache.org/db-derby/_Requirement_Specifications_for_Monitoring_%26_Management_Extensions_using_JMX
> Developers and Users are requested to please look at the document (feature 
> list in particular) and add their own rating to features by adding a coloumn 
> to the table.
> Comments are welcome.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply via email to