[ 
https://issues.apache.org/jira/browse/DERBY-3375?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Rick Hillegas updated DERBY-3375:
---------------------------------

    Attachment: checkMessages.sql
                CheckMessages.java

Thanks for the patch, Dyre. I am attaching two pieces of code which have helped 
me to sanity check this submission:

checkMessages.sql - this script uses the PropertyFileVTI to create views on 
10.3 and 10.2 message files

CheckMessages.java - this holds a procedure which uses those views to sanity 
check the message files

To use this code, you need to build the java class then run the sql script.

On the whole the submission looks pretty solid as far as this sanity checker is 
concerned. I do see three messages whose English text changed between 10.2 and 
10.3 without there being corresponding changes to the other languages in this 
patch. Two of the messages seem to be typos or grammatical corrections in 
English so I think they can be ignored. The remaining message, XJ125.S, appears 
to be a substantive change which is not reflected in the Chinese localizations 
in this patch. Here's the output of my test run:

-------------------------------
--
-- Check the messages.
--
-------------------------------

call checkMessages();
------------------------------------------------------------

The following messages have not been translated into engine_traditional_chinese

The following messages appear more than once in engine_traditional_chinese
The following messages have not been deleted from engine_traditional_chinese
The following messages have changed in English but not in 
engine_traditional_chinese
        42X69
        XJ125.S
        XSDFI.S
------------------------------------------------------------

------------------------------------------------------------

The following messages have not been translated into engine_japanese

The following messages appear more than once in engine_japanese
The following messages have not been deleted from engine_japanese
The following messages have changed in English but not in engine_japanese
        42X69
        XJ125.S
------------------------------------------------------------

------------------------------------------------------------

The following messages have not been translated into engine_italian

The following messages appear more than once in engine_italian
The following messages have not been deleted from engine_italian
The following messages have changed in English but not in engine_italian
        42X69
        XSDFI.S
------------------------------------------------------------

------------------------------------------------------------

The following messages have not been translated into engine_french

The following messages appear more than once in engine_french
The following messages have not been deleted from engine_french
The following messages have changed in English but not in engine_french
        42X69
        XSDFI.S
------------------------------------------------------------

------------------------------------------------------------

The following messages have not been translated into engine_spanish

The following messages appear more than once in engine_spanish
The following messages have not been deleted from engine_spanish
The following messages have changed in English but not in engine_spanish
        42X69
        XSDFI.S
------------------------------------------------------------

------------------------------------------------------------

The following messages have not been translated into engine_korean

The following messages appear more than once in engine_korean
The following messages have not been deleted from engine_korean
The following messages have changed in English but not in engine_korean
        42X69
        XSDFI.S
------------------------------------------------------------

------------------------------------------------------------

The following messages have not been translated into engine_simple_chinese

The following messages appear more than once in engine_simple_chinese
The following messages have not been deleted from engine_simple_chinese
The following messages have changed in English but not in engine_simple_chinese
        42X69
        XJ125.S
        XSDFI.S
------------------------------------------------------------

------------------------------------------------------------

The following messages have not been translated into engine_german

The following messages appear more than once in engine_german
The following messages have not been deleted from engine_german
The following messages have changed in English but not in engine_german
        42X69
        XSDFI.S
------------------------------------------------------------

------------------------------------------------------------

The following messages have not been translated into drda_traditional_chinese

The following messages appear more than once in drda_traditional_chinese
        DRDA_InvalidValue.U
The following messages have not been deleted from drda_traditional_chinese
The following messages have changed in English but not in 
drda_traditional_chinese
------------------------------------------------------------

------------------------------------------------------------

The following messages have not been translated into drda_japanese

The following messages appear more than once in drda_japanese
        DRDA_InvalidValue.U
The following messages have not been deleted from drda_japanese
The following messages have changed in English but not in drda_japanese
------------------------------------------------------------

------------------------------------------------------------

The following messages have not been translated into drda_italian

The following messages appear more than once in drda_italian
        DRDA_InvalidValue.U
The following messages have not been deleted from drda_italian
The following messages have changed in English but not in drda_italian
------------------------------------------------------------

------------------------------------------------------------

The following messages have not been translated into drda_french

The following messages appear more than once in drda_french
        DRDA_InvalidValue.U
The following messages have not been deleted from drda_french
The following messages have changed in English but not in drda_french
------------------------------------------------------------

------------------------------------------------------------

The following messages have not been translated into drda_spanish

The following messages appear more than once in drda_spanish
        DRDA_InvalidValue.U
The following messages have not been deleted from drda_spanish
The following messages have changed in English but not in drda_spanish
------------------------------------------------------------

------------------------------------------------------------

The following messages have not been translated into drda_korean

The following messages appear more than once in drda_korean
        DRDA_InvalidValue.U
The following messages have not been deleted from drda_korean
The following messages have changed in English but not in drda_korean
------------------------------------------------------------

------------------------------------------------------------

The following messages have not been translated into drda_simple_chinese

The following messages appear more than once in drda_simple_chinese
        DRDA_InvalidValue.U
The following messages have not been deleted from drda_simple_chinese
The following messages have changed in English but not in drda_simple_chinese
------------------------------------------------------------

------------------------------------------------------------

The following messages have not been translated into drda_german

The following messages appear more than once in drda_german
        DRDA_InvalidValue.U
The following messages have not been deleted from drda_german
The following messages have changed in English but not in drda_german
------------------------------------------------------------


> Localize new error messages added in 10.3
> -----------------------------------------
>
>                 Key: DERBY-3375
>                 URL: https://issues.apache.org/jira/browse/DERBY-3375
>             Project: Derby
>          Issue Type: Improvement
>          Components: Localization
>    Affects Versions: 10.3.2.1
>            Reporter: Dyre Tjeldvoll
>            Assignee: Dyre Tjeldvoll
>            Priority: Minor
>             Fix For: 10.4.0.0
>
>         Attachments: CheckMessages.java, checkMessages.sql, derby-3375.diff
>
>
> New error messages added in 10.3 have not been localized. Should translate 
> these into as many languages as possible.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply via email to