[
https://issues.apache.org/jira/browse/DERBY-3223?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12613311#action_12613311
]
Knut Anders Hatlen commented on DERBY-3223:
-------------------------------------------
Another simplification you may consider is to remove the close method
from RoleClosureIterator. As far as I can see, the iterator never has
a lifetime that exceeds the lifetime of the objects it refers to, so
the close method doesn't provide any real benefit. Some of the
benefits of removing it are:
- less code
- simpler use of the iterator (no need for a try/finally block)
- some of the member fields can be made final
- saves a couple of CPU cycles
> SQL roles: make use of privileges granted to roles in actual privilege
> checking
> -------------------------------------------------------------------------------
>
> Key: DERBY-3223
> URL: https://issues.apache.org/jira/browse/DERBY-3223
> Project: Derby
> Issue Type: Task
> Components: Security, SQL
> Reporter: Dag H. Wanvik
> Assignee: Dag H. Wanvik
> Fix For: 10.5.0.0
>
> Attachments: derby-3223-1a.diff, derby-3223-1a.stat,
> derby-3223-1b.diff, derby-3223-1b.stat, derby-3223-1c.diff,
> derby-3223-1c.stat, derby-3223-1d.diff, derby-3223-1d.stat,
> derby-3223-activate-roles-1.diff, derby-3223-activate-roles-1.stat,
> derby-3223-revise-iterator-api-b.diff, derby-3223-revise-iterator-api-b.stat,
> derby-3223-revise-iterator-api.diff, derby-3223-revise-iterator-api.stat,
> roles.sql, roles2.sql, roles3.sql
>
>
> Pushing out to 10.5
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
