[
https://issues.apache.org/jira/browse/DERBY-3223?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12613581#action_12613581
]
Knut Anders Hatlen commented on DERBY-3223:
-------------------------------------------
Thanks for the new patch, Dag! It looks good. I agree that it would be better
if the hard-coded strings were in uppercase.
A couple of small nits that I missed in the previous review. Don't let them
stop you from committing. They can be fixed in another patch.
RolesConferredPrivilegesTest:
- two constants (FKVIOLATION and CHECKCONSTRAINTVIOLATED) are indented with
tabs, the rest with spaces
- assertExecutePrivilege() creates a statement that it doesn't close
- assertSelectPrivilege/5 creates a statement that it never uses (nor closes)
- assertPrivilegeMetadata(), isOwner() and formatArgs() create statements
that they don't close
> SQL roles: make use of privileges granted to roles in actual privilege
> checking
> -------------------------------------------------------------------------------
>
> Key: DERBY-3223
> URL: https://issues.apache.org/jira/browse/DERBY-3223
> Project: Derby
> Issue Type: Task
> Components: Security, SQL
> Reporter: Dag H. Wanvik
> Assignee: Dag H. Wanvik
> Fix For: 10.5.0.0
>
> Attachments: derby-3223-1a.diff, derby-3223-1a.stat,
> derby-3223-1b.diff, derby-3223-1b.stat, derby-3223-1c.diff,
> derby-3223-1c.stat, derby-3223-1d.diff, derby-3223-1d.stat,
> derby-3223-activate-roles-1.diff, derby-3223-activate-roles-1.stat,
> derby-3223-activate-roles-2.diff, derby-3223-activate-roles-2.stat,
> derby-3223-revise-iterator-api-b.diff, derby-3223-revise-iterator-api-b.stat,
> derby-3223-revise-iterator-api.diff, derby-3223-revise-iterator-api.stat,
> roles.sql, roles2.sql, roles3.sql
>
>
> Pushing out to 10.5
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
