[
https://issues.apache.org/jira/browse/DERBY-3223?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12623443#action_12623443
]
Rick Hillegas commented on DERBY-3223:
--------------------------------------
Thanks for the patch, Dag. A couple small comments:
o General - Some of the paragraphs in the explanatory text file might make good
source code comments which would help the next person who walks through this
code.
o DDLConstantAction - It would be helpful if findRoleUsage() and
trackRoleDependency() had header comments.
o StatementTablePermission.hasPermissionOnTable() - The name of this method
indicates that it is just checking for permissions, but the method can have the
side-effect of creating an in-memory dependency. It would be good if the
method's header mentioned this side-effect.
o StatementColumnPermission.allColumnsCoveredByUserOrPUBLIC() - The first line
of the header comment says that the method returns true if the permissions
depend on the current role. But the @return clause says the opposite. I think
that the @return clause agrees with the actual implementation.
> SQL roles: make use of privileges granted to roles in actual privilege
> checking
> -------------------------------------------------------------------------------
>
> Key: DERBY-3223
> URL: https://issues.apache.org/jira/browse/DERBY-3223
> Project: Derby
> Issue Type: Task
> Components: Security, SQL
> Reporter: Dag H. Wanvik
> Assignee: Dag H. Wanvik
> Fix For: 10.5.0.0
>
> Attachments: derby-3223-1a.diff, derby-3223-1a.stat,
> derby-3223-1b.diff, derby-3223-1b.stat, derby-3223-1c.diff,
> derby-3223-1c.stat, derby-3223-1d.diff, derby-3223-1d.stat,
> derby-3223-activate-roles-1.diff, derby-3223-activate-roles-1.stat,
> derby-3223-activate-roles-2.diff, derby-3223-activate-roles-2.stat,
> derby-3223-activate-roles-2b.diff, derby-3223-activate-roles-2b.stat,
> derby-3223-revise-iterator-api-b.diff, derby-3223-revise-iterator-api-b.stat,
> derby-3223-revise-iterator-api.diff, derby-3223-revise-iterator-api.stat,
> derby-3223-revocation-logic-1.diff, derby-3223-revocation-logic-1.stat,
> derby-3223-revocation-logic-2.diff, derby-3223-revocation-logic-2.stat,
> derby-3223-revocation-logic-2.txt, derby-3223-revocation-logic-3.diff,
> derby-3223-revocation-logic-3.stat, roles.sql, roles2.sql, roles3.sql
>
>
> Pushing out to 10.5
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
