[ 
https://issues.apache.org/jira/browse/DERBY-4786?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12907662#action_12907662
 ] 

Kathey Marsden commented on DERBY-4786:
---------------------------------------

Hi Mamta, I will look at the patch today but to answer your question, I think 
the  behavior  you have  is fine with existing old versions but we should 
backport the recognition of level 2 protocol to the early branches so users 
running on the latest version on the branch, won't see the error.  I think we 
should be careful to document that moving forward, instead of changing existing 
commands, new API's  should create a new COMMAND_XXX command instead of bumping 
the protocol version. Maybe a big  code comment around PROTOCOL_VERSION would 
be a good  place to put this.

It would be good to have some sort of automated test for this. The comments in 
DERBY-3644 seem to indicate that the compatibility tests exposed the problem.   
Are those still run anywhere?


> Shutdown command without username and password should work with mixed client 
> and network server releases.
> ---------------------------------------------------------------------------------------------------------
>
>                 Key: DERBY-4786
>                 URL: https://issues.apache.org/jira/browse/DERBY-4786
>             Project: Derby
>          Issue Type: Bug
>          Components: Network Client, Network Server
>    Affects Versions: 10.4.1.3, 10.4.2.0, 10.5.1.1, 10.6.1.0
>            Reporter: Mamta A. Satoor
>            Assignee: Mamta A. Satoor
>         Attachments: DERBY4786_patch1_diff.txt, DERBY4786_patch2_diff.txt
>
>
> DERBY-2109 introduced optional parameters username and password to the 
> shutdown command. But with this fix, the existing shutdown command which does 
> not use username and password stopped working from client with DERBY-2109 
> changes against a network server without DERBY-2109 changes.
> This jira is to ensure that existing shutdown command without user name and 
> password still works fine between different releases of client and network 
> server(with or without DERBY-2109). The new shutdown command introduced by 
> DERBY-2109 will work obviosuly only on client and server with DERBY-2109 
> changes. For client/server not with DERBY-2109 changes attempting to user use 
> name and password will get an error.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply via email to