[
https://issues.apache.org/jira/browse/DERBY-5382?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13208531#comment-13208531
]
Myrna van Lunteren commented on DERBY-5382:
-------------------------------------------
I tried the patch, and I'll have a closer look too, but from first glance I
have the following comments:
- The old test files were removed, but they're still referenced in the
functionTests.suites.storerecovery.runall file.
- the masters for the original tests were not removed
- When I ran the test, I got an error - perhaps the conversion has gone out of
sync with the test. I'll investigate, unless Siddarth is still actively working
on this?
This is the error I saw:
------------------
1)
testOCRecovery_1(org.apache.derbyTesting.functionTests.tests.store.OCRecoveryTest)
junit.framework.AssertionFailedError: expectedExitValue:0 does not
match exitValue:1
expected output strings:
[0]OK (1 test)
actual output:<STDOUT> <END STDOUT>
<STDERR>Class not found
"org.apache.derbyTesting.functionTests.tests.store.OCRecoveryTest.launchOCRecovery_2"
<END STDERR>
expected:<0> but was:<1>
at
org.apache.derbyTesting.junit.BaseTestCase.assertExecJavaCmdAsExpected(BaseTestCase.java:513)
at
org.apache.derbyTesting.junit.BaseTestCase.assertLaunchedJUnitTestMethod(BaseTestCase.java:838)
at
org.apache.derbyTesting.functionTests.tests.store.OCRecoveryTest.testOCRecovery_1(OCRecoveryTest.java:78)
at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
at
sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:60)
at
sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:37)
at
org.apache.derbyTesting.junit.BaseTestCase.runBare(BaseTestCase.java:113)
at junit.extensions.TestDecorator.basicRun(TestDecorator.java:22)
at junit.extensions.TestSetup$1.protect(TestSetup.java:19)
at junit.extensions.TestSetup.run(TestSetup.java:23)
at org.apache.derbyTesting.junit.BaseTestSetup.run(BaseTestSetup.java:57
)
> Convert existing harness recovery tests to JUnit tests
> ------------------------------------------------------
>
> Key: DERBY-5382
> URL: https://issues.apache.org/jira/browse/DERBY-5382
> Project: Derby
> Issue Type: Improvement
> Reporter: Siddharth Srivastava
> Assignee: Siddharth Srivastava
> Attachments: d5382.patch
>
>
> Existing harness recovery tests need to be converted to JUnit tests. A
> framework as designed in Derby-4249 can be used for this purpose.
> Tests to be converted:
> a) oc_rec1
> b) oc_rec2
> c) oc_rec3
> d) oc_rec4
> These recovery tests run in coordination. The test oc_rec1 creates a table,
> inserts and then deletes rows from it and commit it which is followed by a
> series of insertion of rows in the existing table in oc_rec2, oc_rec3 and
> oc_rec4. The tests oc_rec2 and oc_3 also create table and insert, delete,
> compress rows in it and leave the table thus produced in committed or
> uncommitted state which is tested by the next corresponding test (oc_rec3 for
> oc_rec2, oc_rec4 for oc_rec3) for recovery.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
