[
https://issues.apache.org/jira/browse/DERBY-5382?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13212956#comment-13212956
]
Myrna van Lunteren commented on DERBY-5382:
-------------------------------------------
I've looked at that failure a bit closer, and realized I was picking up an old
version (3.8.1) of junit.
The test passes with junit 3.8.2, (which allows for the -m option to run
fixture/methods).
I think the test conversion is good as it is.
I ran the test by itself a couple of times, and in the store suite, and I did
not see any of the problems Siddarth mentioned, so I am assuming they're
related to environment issues, or issues that were current at the time the
original patch was created.
I did remove the reference from storetests.runall, deleted the master, and made
a few minor changes:
- using setAutoCommit() and createStatement() instead of creating a connection
first.
This was already done in the createAndLoadTable() method, but not in the
launchOCRecovery_* methods, and I didn't see a reason for not doing this
elsewhere.
- remove the System.out.println("in test 1") which seemed to me a left-over
from a debugging action.
- broke up a few lines that went > 80 characters.
(the coding practice for derby is comments not to go longer, but it doesn't
hurt for code
to follow the same rule).
I committed the patch (with my modifications) with revision 1292027.
Thank you Siddarth!
> Convert existing harness recovery tests to JUnit tests
> ------------------------------------------------------
>
> Key: DERBY-5382
> URL: https://issues.apache.org/jira/browse/DERBY-5382
> Project: Derby
> Issue Type: Improvement
> Components: Test
> Reporter: Siddharth Srivastava
> Assignee: Siddharth Srivastava
> Fix For: 10.9.0.0
>
> Attachments: d5382.patch
>
>
> Existing harness recovery tests need to be converted to JUnit tests. A
> framework as designed in Derby-4249 can be used for this purpose.
> Tests to be converted:
> a) oc_rec1
> b) oc_rec2
> c) oc_rec3
> d) oc_rec4
> These recovery tests run in coordination. The test oc_rec1 creates a table,
> inserts and then deletes rows from it and commit it which is followed by a
> series of insertion of rows in the existing table in oc_rec2, oc_rec3 and
> oc_rec4. The tests oc_rec2 and oc_3 also create table and insert, delete,
> compress rows in it and leave the table thus produced in committed or
> uncommitted state which is tested by the next corresponding test (oc_rec3 for
> oc_rec2, oc_rec4 for oc_rec3) for recovery.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
