[ 
https://issues.apache.org/jira/browse/DERBY-5382?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13215204#comment-13215204
 ] 

Myrna van Lunteren commented on DERBY-5382:
-------------------------------------------

I adjusted the test as per Mike's comments - so now all steps are in forkable 
methods except the creation of the database.
I committed these changes with revision 1293028 with the following comment:
  follow up patch, which
  - removes shutdowns which were preventing any recovery to happen
  - makes the first step a separate forkable method
  - adds some comments

Note, that the comments in oc_rec2 didn't exactly reflect the steps, it said:
 'create table, delete rows, compress, add rows, commit' but there were no rows 
getting added after the compress. So I removed the 'add rows' from the comment 
in the new test.
                
> Convert existing harness recovery tests to JUnit tests
> ------------------------------------------------------
>
>                 Key: DERBY-5382
>                 URL: https://issues.apache.org/jira/browse/DERBY-5382
>             Project: Derby
>          Issue Type: Improvement
>          Components: Test
>            Reporter: Siddharth Srivastava
>            Assignee: Siddharth Srivastava
>             Fix For: 10.9.0.0
>
>         Attachments: DERBY-5382.diff, d5382.patch
>
>
> Existing harness recovery tests need to be converted to JUnit tests. A 
> framework as designed in Derby-4249 can be used for this purpose.
> Tests to be converted:
> a) oc_rec1
> b) oc_rec2
> c) oc_rec3
> d) oc_rec4
> These recovery tests run in coordination. The test oc_rec1 creates a table, 
> inserts and then deletes rows from it and commit it which is followed by a 
> series of insertion of rows in the existing table in oc_rec2, oc_rec3 and 
> oc_rec4. The tests oc_rec2 and oc_3 also create table and insert, delete, 
> compress rows in it and leave the table thus produced in committed or 
> uncommitted state which is tested by the next corresponding test (oc_rec3 for 
> oc_rec2, oc_rec4 for oc_rec3) for recovery.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Reply via email to