After some further thought -- and a bunch of chitchat with Jeremy
Epstein that was really helpful -- I see that there's a better solution
to the first of the two scenarios that doesn't involve throwing up a
dialog at all.
The two scenarios are:
1. Users click on the lozenge for the same event they are editing in the
item detail form
A dialog box is actually not needed here, because the user's intent is
clear.
The UI should just do the right thing in that case, and apply edits from
the form along with the changes to start and end time caused by
moving/resizing the lozenge. (If the changes in the form include a
change to start/end, then the move/resize changes would overwrite them.)
2. Users click on the lozenge for a different event.
Here we still need the dialog to ask users if they want to apply
changes, discard changes, or cancel the change of selection to the new
event.
This seems to me like a fairly obvious improvement in the case of number
1, so unless there are some objections, I'll take this tack when doing
the fix for this bug.
On a related note, in talking about this with both Priscilla (and later
Jeremy as well), some interesting questions came up regarding the
behavior of saving changes to items in the Chandler Server Web UI. This
can of worms was opened up by the question of how to implement
edit-in-place for the event title directly on the lozenge. (There's an
open bug, no. 7849, for this.)
I'll address that stuff in a separate e-mail to the list.
Matthew.
Matthew Eernisse wrote:
I agree that 'Discard' is better. I'd also like to propose a change to
the prompt that makes it clearer why the dialog has popped up. I propose
the following:
You have made changes to the currently selected item. Do you want to
save your changes?
[Cancel] [Discard] [Save]
I do kind of like the addition of the word 'Changes' in the two
right-hand buttons. (And I'm usually a fan of one-word button labels.)
It makes it totally clear what the choices are, even if the user doesn't
really bother to read the prompt. It also underlines more clearly the
difference between discarding the changes and proceeding, and canceling
and going back to the state you were in before.
I do however think the button labels are perfectly usable as-is.
Matthew
Priscilla Chung wrote:
Last call…? -Priscilla
On Apr 24, 2007, at 12:37 PM, Priscilla Chung wrote:
If people don't feel strongly about the proposed buttons, then let's
finalize a decision on this proposal. ---
Save changes?
[Cancel] [Discard] [Save]
------------------------------------------------------------------------
_ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _
Open Source Applications Foundation "Design" mailing list
http://lists.osafoundation.org/mailman/listinfo/design
_ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _
Open Source Applications Foundation "Design" mailing list
http://lists.osafoundation.org/mailman/listinfo/design
_ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _
Open Source Applications Foundation "Design" mailing list
http://lists.osafoundation.org/mailman/listinfo/design
