dghgit commented on issue #455:
URL: https://github.com/apache/mina-sshd/issues/455#issuecomment-1911900710

   @tomaswolf apologies if I offended, I was not trying to get a raise out of 
anyone but the use of the JCE Cipher class is **_wrong by inspection_**. If the 
API is modified to conform to the Cipher class as documented in the JCE spec 
you should find that the code will happily support both hardware and software 
providers that are compliant with the JCE spec.
   And yes, the issue is that the calling code is not recognising that the 
cipher class is buffering input which it is allowed to do and which is why the 
return values from Cipher.update() and Cipher.doFinal() **must** be checked. 
This means that the calling code thinks it is getting back data but is instead 
leaving the the array filled with zeros. The "miracle" may also be that both 
sides in a lot of cases are just decrypting to strings of zeros, I'm not sure 
that's the effect that's being looked for.

This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@mina.apache.org

For queries about this service, please contact Infrastructure at:

To unsubscribe, e-mail: dev-unsubscr...@mina.apache.org
For additional commands, e-mail: dev-h...@mina.apache.org

Reply via email to