dghgit commented on issue #455: URL: https://github.com/apache/mina-sshd/issues/455#issuecomment-1912880577
Okay, it's not strictly correct, but assuming the protocol is never using a padded mode when it comes down this path the above should be okay (I think) - the assert should catch the use of padding if it's the case anyway (the return value of doFinal() becomes significant if padding is being added (as it is on encryption) or removed (as can happen on decryption)). It might be worth adding a comment above it to explain what it will mean if the assert fails ``` // fail if the cipher is using padding - requires special handling ``` To save someone later should the status quo change. I assume it's trying to avoid re-intializing the cipher where it's not really required? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@mina.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@mina.apache.org For additional commands, e-mail: dev-h...@mina.apache.org
