[ 
https://issues.apache.org/jira/browse/NUTCH-3130?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18031019#comment-18031019
 ] 

ASF GitHub Bot commented on NUTCH-3130:
---------------------------------------

lewismc commented on code in PR #869:
URL: https://github.com/apache/nutch/pull/869#discussion_r2443605899


##########
src/java/org/apache/nutch/indexer/IndexWriter.java:
##########
@@ -30,15 +30,6 @@ public interface IndexWriter extends Pluggable, Configurable 
{
    */
   final static String X_POINT_ID = IndexWriter.class.getName();
 
-  /**
-   * @param conf Nutch configuration
-   * @param name target name of the {@link IndexWriter} to be opened
-   * @throws IOException Some exception thrown by some writer.
-   * @deprecated use {@link #open(IndexWriterParams)}} instead.  
-   */
-  @Deprecated

Review Comment:
   Are we OK with removing this deprecated method altogether?





> Address deprecated API usage across Nutch codebase and build
> ------------------------------------------------------------
>
>                 Key: NUTCH-3130
>                 URL: https://issues.apache.org/jira/browse/NUTCH-3130
>             Project: Nutch
>          Issue Type: Improvement
>          Components: build, ci/cd, dependency
>    Affects Versions: 1.21
>            Reporter: Lewis John McGibbney
>            Assignee: Lewis John McGibbney
>            Priority: Major
>             Fix For: 1.22
>
>
> A long time ago I performed a similar task 
> (https://issues.apache.org/jira/browse/NUTCH-1273) to address all deprecation 
> warnings flagged across the Nutch codebase.
> This time around I want to do the same but also plan to include a deprecation 
> check as part of GitHub CI so we keep on top of deprecation issues into the 
> future.
> Patch coming up.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

Reply via email to