[
https://issues.apache.org/jira/browse/NUTCH-3130?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18031024#comment-18031024
]
ASF GitHub Bot commented on NUTCH-3130:
---------------------------------------
lewismc commented on code in PR #869:
URL: https://github.com/apache/nutch/pull/869#discussion_r2443607704
##########
src/java/org/apache/nutch/plugin/Plugin.java:
##########
@@ -88,9 +88,4 @@ public PluginDescriptor getDescriptor() {
private void setDescriptor(PluginDescriptor descriptor) {
fDescriptor = descriptor;
}
-
- @Override
- protected void finalize() throws Throwable {
- shutDown();
Review Comment:
I'm not sure we can simply remove the call to shutdown. I need to further
investigate options and confirm.
> Address deprecated API usage across Nutch codebase and build
> ------------------------------------------------------------
>
> Key: NUTCH-3130
> URL: https://issues.apache.org/jira/browse/NUTCH-3130
> Project: Nutch
> Issue Type: Improvement
> Components: build, ci/cd, dependency
> Affects Versions: 1.21
> Reporter: Lewis John McGibbney
> Assignee: Lewis John McGibbney
> Priority: Major
> Fix For: 1.22
>
>
> A long time ago I performed a similar task
> (https://issues.apache.org/jira/browse/NUTCH-1273) to address all deprecation
> warnings flagged across the Nutch codebase.
> This time around I want to do the same but also plan to include a deprecation
> check as part of GitHub CI so we keep on top of deprecation issues into the
> future.
> Patch coming up.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
