[
https://issues.apache.org/jira/browse/NUTCH-3130?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18031020#comment-18031020
]
ASF GitHub Bot commented on NUTCH-3130:
---------------------------------------
lewismc commented on code in PR #869:
URL: https://github.com/apache/nutch/pull/869#discussion_r2443606491
##########
src/java/org/apache/nutch/indexer/IndexWriters.java:
##########
@@ -211,7 +211,7 @@ private Collection<String> getIndexWriters(NutchDocument
doc) {
public void open(Configuration conf, String name) throws IOException {
for (Map.Entry<String, IndexWriterWrapper> entry : this.indexWriters
.entrySet()) {
- entry.getValue().getIndexWriter().open(conf, name);
+ entry.getValue().getIndexWriter().open(new IndexWriterParams(new
HashMap<>()));
Review Comment:
Are these the correct method parameters if we were to remove the deprecated
`open(Configuration conf, String name)` method?
> Address deprecated API usage across Nutch codebase and build
> ------------------------------------------------------------
>
> Key: NUTCH-3130
> URL: https://issues.apache.org/jira/browse/NUTCH-3130
> Project: Nutch
> Issue Type: Improvement
> Components: build, ci/cd, dependency
> Affects Versions: 1.21
> Reporter: Lewis John McGibbney
> Assignee: Lewis John McGibbney
> Priority: Major
> Fix For: 1.22
>
>
> A long time ago I performed a similar task
> (https://issues.apache.org/jira/browse/NUTCH-1273) to address all deprecation
> warnings flagged across the Nutch codebase.
> This time around I want to do the same but also plan to include a deprecation
> check as part of GitHub CI so we keep on top of deprecation issues into the
> future.
> Patch coming up.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
