[
http://jira.magnolia-cms.com/browse/MAGNOLIA-3094?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Grégory Joseph updated MAGNOLIA-3094:
-------------------------------------
Attachment: use-contextPath.patch
Have a look at this patch - it's missing the tests (i have some locally), the
log statement that logs {contextPath} next to the other variables, and the same
change in the default web.xml, but that's pretty much all it does. So, unless
I'm missing something, it would not require users to upgrade anything. It would
just provide the extra feature for those who have.
Granted, it might not be very useful in production, when you often have an
empty contextPath - but not always, and when you do, using the "real"
contextPath is probably a better solution than the directory name
({{\{webapp}}}) which can be somewhat random, depending on your container.
Let me know what you think.
> Also use contextPath when resolving magnolia.properties files at startup
> ------------------------------------------------------------------------
>
> Key: MAGNOLIA-3094
> URL: http://jira.magnolia-cms.com/browse/MAGNOLIA-3094
> Project: Magnolia
> Issue Type: Improvement
> Components: core
> Reporter: Grégory Joseph
> Assignee: Philipp Bärfuss
> Fix For: 4.3
>
> Attachments: use-contextPath.patch
>
>
> When looking up {{magnolia.properties}} [1] files, we're using the current
> host name, as well as the webapp folder name (i.e the last element of the
> path in which the webapp is deployed) - which is not necessarily the servlet
> context path for the webapp.
> Using the webapp's context path might help in a bunch of situations (while
> developing I often have a context path differing from the webapp's name. same
> goes when deploying multiple apps under different vhosts of a single tomcat,
> for instance; some appservers deploy their webapps in folder whose name
> doesn't correspond to the contextPath either)
> Unfortunately, {{javax.servlet.ServletContext#getContextPath}} is only
> available since the 2.5 version of the Servlet API. Can we update ?
> (marking this as fix-for 4.3, only in the case we can quickly decide on
> upgrading the servlet api dependency, in which case adding this should be
> trivial)
> [1]
> http://documentation.magnolia-cms.com/cookbook/using-a-single-war-file-with-multiple-configurations.html
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://jira.magnolia-cms.com/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
----------------------------------------------------------------
For list details see
http://www.magnolia-cms.com/home/community/mailing-lists.html
To unsubscribe, E-mail to: <[email protected]>
----------------------------------------------------------------
