[ 
http://jira.magnolia-cms.com/browse/MAGNOLIA-3094?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=26689#action_26689
 ] 

Danilo Ghirardelli commented on MAGNOLIA-3094:
----------------------------------------------

As I said in the other issue, wouldn't be better if we make this property 
initialization configurable just like the other parts of Magnolia? I mean, 
everybody seems to have his own way to "stretch" property initialization, 
depending on customer configuration and habits, and none seems to be better or 
more flexible than others. So it would be nice to have the PropertyInitializer 
class set (optionally) in the web.xml just like the 
magnolia.initialization.file. Something like 
magnolia.property.initialization.class = MyOwnPropertyInitializer. So Magnolia 
will delegate to the given class the property init, with an obvious fallback to 
the default one (the existing one). This shuold cover also most of the corner 
cases, API updates and so on.

> Also use contextPath when resolving magnolia.properties files at startup
> ------------------------------------------------------------------------
>
>                 Key: MAGNOLIA-3094
>                 URL: http://jira.magnolia-cms.com/browse/MAGNOLIA-3094
>             Project: Magnolia
>          Issue Type: Improvement
>          Components: core
>            Reporter: Grégory Joseph
>            Assignee: Philipp Bärfuss
>             Fix For: 4.3
>
>         Attachments: contextPath_in_PropertiesInitializer.patch, 
> use-contextPath.patch
>
>
> When looking up {{magnolia.properties}} [1] files, we're using the current 
> host name, as well as the webapp folder name (i.e the last element of the 
> path in which the webapp is deployed) - which is not necessarily the servlet 
> context path for the webapp.
> Using the webapp's context path might help in a bunch of situations (while 
> developing I often have a context path differing from the webapp's name. same 
> goes when deploying multiple apps under different vhosts of a single tomcat, 
> for instance; some appservers deploy their webapps in folder whose name 
> doesn't correspond to the contextPath either)
> Unfortunately, {{javax.servlet.ServletContext#getContextPath}} is only 
> available since the 2.5 version of the Servlet API. Can we update ? 
> (marking this as fix-for 4.3, only in the case we can quickly decide on 
> upgrading the servlet api dependency, in which case adding this should be 
> trivial)
> [1] 
> http://documentation.magnolia-cms.com/cookbook/using-a-single-war-file-with-multiple-configurations.html

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: 
http://jira.magnolia-cms.com/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira



----------------------------------------------------------------
For list details see
http://www.magnolia-cms.com/home/community/mailing-lists.html
To unsubscribe, E-mail to: <[email protected]>
----------------------------------------------------------------

Reply via email to