[
http://jira.magnolia-cms.com/browse/MAGNOLIA-3094?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=26686#action_26686
]
Fabrizio Giustina commented on MAGNOLIA-3094:
---------------------------------------------
Yes, I am concerned about using 2.5 api by mistake and I don't think that
setting up a tool like animal sniffer is a good solution.
We similary have the tools that analyze binary incompatibility between releases
and we are still breaking things without noticing...
Why are you so concerned about using reflection anyway? I think it's a lot
easier, simple and safe... just replace the servletContext.getContextPath call
with PropertyUtils.getProperty(servletContext, "contextPath") and save the
change in the pom.xml dependency...
> Also use contextPath when resolving magnolia.properties files at startup
> ------------------------------------------------------------------------
>
> Key: MAGNOLIA-3094
> URL: http://jira.magnolia-cms.com/browse/MAGNOLIA-3094
> Project: Magnolia
> Issue Type: Improvement
> Components: core
> Reporter: Grégory Joseph
> Assignee: Philipp Bärfuss
> Fix For: 4.3
>
> Attachments: contextPath_in_PropertiesInitializer.patch,
> use-contextPath.patch
>
>
> When looking up {{magnolia.properties}} [1] files, we're using the current
> host name, as well as the webapp folder name (i.e the last element of the
> path in which the webapp is deployed) - which is not necessarily the servlet
> context path for the webapp.
> Using the webapp's context path might help in a bunch of situations (while
> developing I often have a context path differing from the webapp's name. same
> goes when deploying multiple apps under different vhosts of a single tomcat,
> for instance; some appservers deploy their webapps in folder whose name
> doesn't correspond to the contextPath either)
> Unfortunately, {{javax.servlet.ServletContext#getContextPath}} is only
> available since the 2.5 version of the Servlet API. Can we update ?
> (marking this as fix-for 4.3, only in the case we can quickly decide on
> upgrading the servlet api dependency, in which case adding this should be
> trivial)
> [1]
> http://documentation.magnolia-cms.com/cookbook/using-a-single-war-file-with-multiple-configurations.html
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://jira.magnolia-cms.com/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
----------------------------------------------------------------
For list details see
http://www.magnolia-cms.com/home/community/mailing-lists.html
To unsubscribe, E-mail to: <[email protected]>
----------------------------------------------------------------
