A few follow-up comments having been looking through some of the bugs:
Getting Call Information --------------------The mix of "GET /call/{token}" and "GET /calls?version=" is confusing - to know which calls we have incoming, we have to get /calls, but the new "GET /call/{token}" is going to give us the part of the information we need to display before the call is accepted.
So we'd have to do both calls before being able to display anything to the user.
I think we should either have just one call, or be making /calls just the information about which calls I've got incoming for a particular push url version, with an id for each one (in the case of multiple).
The /call/{token} should then be all the information I need to start and run the call, i.e. the caller information (id, name, call_url), and the call setup information (session ids etc).
Extra Call Information ------------------According to https://people.mozilla.org/~dhenein/labs/loop-mvp-spec/#call-incoming-unknown we should have the date the url was generated - I don't see that in the docs currently.
Which Calls ----------Should we also change /calls?version= to only ever return one call? Currently if two incoming calls came in close together, we'd be getting duplicate information for the second call.
(I'm assuming that the servers don't amalgamate push notifications to the client).
Whilst I can see that returning the incoming calls since a particular version is useful, it only makes sense if we're going to check on startup or in history for missed calls, and I don't see that as a requirement at the moment.
Hence this confuses how the application should be handling the case where /calls?version= returns more than one call.
Call URL generation and identification ------------In "POST /call-url" I believe the callerId parameter should now become optional or removed, as the user may or may not specify it.
Although, I'm actually a bit puzzled, as I thought in an earlier version of the document, you could specify the caller id and duration separate to getting the call url, but this seems to have been lost.
This additional set-up would be required as per the discussion in bug 1000770.
Mark.
smime.p7s
Description: S/MIME Cryptographic Signature
_______________________________________________ dev-media mailing list [email protected] https://lists.mozilla.org/listinfo/dev-media
