On 26/06/13 18:13, Ehsan Akhgari wrote: > On 2013-06-26 12:17 PM, Andrew Overholt wrote: >> On 26/06/13 11:48 AM, Ehsan Akhgari wrote: >>> On 2013-06-26 11:21 AM, Andrew Overholt wrote: >>>> On 24/06/13 05:52 PM, Ehsan Akhgari wrote: >>>>> There are two things that I think can use clarification. One is what >>>>> we're going to do about "trivial changes"? Do all web facing features >>>>> ned to go through this process? >>>> >>>> I was going to put a blurb about "trivial changes" but thought it would >>>> be too hard to define. >> >> Sorry, I was wrong here. I didn't put it in because I intended the >> policy to only cover new APIs. I guess we could say "new APIs or major >> changes to existing APIs" ... > > Well, the policy also mentions enforcement through commit hooks (which I > don't like!) so it at least looks to cover all API changes.
It is very easy to do a sr for a trivial change. I very often get sr requests for simple changes by the RIL team. It usually takes me a couple of minutes to open the bug, have a quick look and sr+. The benefit of that is that a few times, I was able to reject some changes that were not needed or not right. The only issue in making sr+ mandatory for trivial changes is that authors might wait too long for simple changes because reviewers are staying behind their review queue. I think this is a general problem we should solve instead of designing other processes around it. -- Mounir _______________________________________________ dev-platform mailing list [email protected] https://lists.mozilla.org/listinfo/dev-platform
