On Tuesday 2013-07-09 15:46 -0400, Boris Zbarsky wrote: > * When requesting a second review on a patch, provide an interdiff > so that the reviewer can just verify that the changes you made match > what they asked for. Bugzilla's interdiff is totally unsuitable for > this purpose, unfortunately, because it fails so often.
For what it's worth, I've learned to read diffs of diffs, and I don't consider it that hard a skill to learn. I read diffs of diffs for nearly all re-reviews that I do (even ignoring any interdiff in the bug). Given one of: alias vs="wget -q -O -" alias vs="curl -s" alias vs="lynx -source" I just use (in bash): diff -u <(vs 'https://bugzilla.mozilla.org/attachment.cgi?id=688611') <(vs 'https://bugzilla.mozilla.org/attachment.cgi?id=696690') | less -S Speaking of re-reviews, I wish bugzilla had a way to indicate that, since I often get re-reviews long enough after the original review that I've forgotten it's a re-review. And I prefer to prioritize re-reviews highest because it helps me get through the reviews faster, since it will be faster if I still remember what I was thinking during the first review. -David -- š¯„˛ L. David Baron http://dbaron.org/ š¯„‚ š¯„¢ Mozilla http://www.mozilla.org/ š¯„‚ _______________________________________________ dev-platform mailing list dev-platform@lists.mozilla.org https://lists.mozilla.org/listinfo/dev-platform
