We've decided to put this off at least 66.

On 2018/11/30 10:37, Masayuki Nakano wrote:
Summary: We'll set keyCode of "keypress" event to its charCode value if keyCode is 0, charCode of "keypress" event to its keyCode value if charCode is 0.

Bug: https://bugzilla.mozilla.org/show_bug.cgi?id=1479964

Link to standard: "conflated model" of https://w3c.github.io/uievents/#determine-keypress-keyCode (we've used "split model"). But no declaration of charCode value of Enter key press.

(Oh, I had not realized this section when I wrote the commit message...)

Platform coverage: All

Estimated or target release: 65

DevTools bug: N/A

Do other browser engines implement this?

Yes, the other browsers use this behavior traditionally, and UI Events declared this behavior as "conflated model".

web-platform-tests: N/A due to requiring user input, but we have mochitests with synthesized events.

This new behavior was enabled in Nightly since early of 65. This caused breaking Google Closure Library.  However, it have been fixed by the cooperation of the developers.

Of course, we may meet other broken web apps especially in intranet. While we're testing this behavior in Nightly, we used blacklist pref (dom.keyboardevent.keypress.hack.use_legacy_keycode_and_charcode) to disable this new behavior only in specific domains.  If we'll get broken web apps even after release, we and users can disable it with using this blacklist.

Enabling patch has been landed from:
because we need to manage those changes as a set.

Masayuki Nakano <masay...@d-toybox.com>
Software Engineer, Mozilla
dev-platform mailing list

Reply via email to