> On March 19, 2014, 3:26 p.m., Sean Busbey wrote: > > core/src/main/java/org/apache/accumulo/core/client/impl/InstanceFactory.java, > > lines 21-23 > > <https://reviews.apache.org/r/19409/diff/1/?file=528072#file528072line21> > > > > Depending on the outcome of the discussion about what version this is > > public or internal use, a note about why this is in the impl package and > > not public would be a good addition for the javadocs. > > Bill Havanki wrote: > Yes! I forgot I wanted to add that kind of note. Regardless of the > outcome, I expect to have this stuff in the public API for 1.7.
Yes! I forgot I wanted to add that kind of note, thank you. Regardless of the outcome, I expect to have this stuff in the public API for 1.7. - Bill ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/19409/#review37773 ----------------------------------------------------------- On March 19, 2014, 12:44 p.m., Bill Havanki wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/19409/ > ----------------------------------------------------------- > > (Updated March 19, 2014, 12:44 p.m.) > > > Review request for accumulo. > > > Bugs: ACCUMULO-2497 > https://issues.apache.org/jira/browse/ACCUMULO-2497 > > > Repository: accumulo > > > Description > ------- > > To help in testing, this commit adds an InstanceFactory interface with some > implementations. > > To avoid changing the public API, some classes are in o.a.a.core.client.impl. > > > Diffs > ----- > > > core/src/main/java/org/apache/accumulo/core/client/impl/InstanceFactory.java > PRE-CREATION > > core/src/main/java/org/apache/accumulo/core/client/impl/ZooKeeperInstanceFactory.java > PRE-CREATION > > core/src/test/java/org/apache/accumulo/core/client/impl/ZooKeeperInstanceFactoryTest.java > PRE-CREATION > > server/base/src/main/java/org/apache/accumulo/server/client/HdfsZooInstanceFactory.java > PRE-CREATION > > server/base/src/test/java/org/apache/accumulo/server/client/HdfsZooInstanceFactoryTest.java > PRE-CREATION > > Diff: https://reviews.apache.org/r/19409/diff/ > > > Testing > ------- > > Unit tests pass. > > > Thanks, > > Bill Havanki > >
