> On March 19, 2014, 6:33 p.m., Mike Drob wrote: > > core/src/main/java/org/apache/accumulo/core/client/impl/InstanceFactory.java, > > line 37 > > <https://reviews.apache.org/r/19409/diff/1/?file=528072#file528072line37> > > > > The problem here is that client code can never catch an > > InstanceFactoryException because it's not scoped public. So, in essense, > > you'd be throwing a RuntimeException with a slightly nicer message. > > > > I appreciate the idea of future proofing the code, but in all > > likelyhood, YAGNI. And since it's an unchecked exception, it is *really* > > easy to add it in later if we want to. > > John Vines wrote: > Can you please reply to comments instead of creating a new review, it > makes it difficult to follow conversations. > > Sean Busbey wrote: > Probably Mike is looking at the Diff view and attempting to reply there, > which opens new issues.
Yep. - Mike ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/19409/#review37758 ----------------------------------------------------------- On March 19, 2014, 4:44 p.m., Bill Havanki wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/19409/ > ----------------------------------------------------------- > > (Updated March 19, 2014, 4:44 p.m.) > > > Review request for accumulo. > > > Bugs: ACCUMULO-2497 > https://issues.apache.org/jira/browse/ACCUMULO-2497 > > > Repository: accumulo > > > Description > ------- > > To help in testing, this commit adds an InstanceFactory interface with some > implementations. > > To avoid changing the public API, some classes are in o.a.a.core.client.impl. > > > Diffs > ----- > > > core/src/main/java/org/apache/accumulo/core/client/impl/InstanceFactory.java > PRE-CREATION > > core/src/main/java/org/apache/accumulo/core/client/impl/ZooKeeperInstanceFactory.java > PRE-CREATION > > core/src/test/java/org/apache/accumulo/core/client/impl/ZooKeeperInstanceFactoryTest.java > PRE-CREATION > > server/base/src/main/java/org/apache/accumulo/server/client/HdfsZooInstanceFactory.java > PRE-CREATION > > server/base/src/test/java/org/apache/accumulo/server/client/HdfsZooInstanceFactoryTest.java > PRE-CREATION > > Diff: https://reviews.apache.org/r/19409/diff/ > > > Testing > ------- > > Unit tests pass. > > > Thanks, > > Bill Havanki > >
