-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/19409/
-----------------------------------------------------------
(Updated March 19, 2014, 5:45 p.m.)
Review request for accumulo.
Changes
-------
Resolves Mike's issues: whitespace, createNiceMock, no static wildcard imports.
Changes InstanceFactoryException to extend commons-lang 3
ContextedRuntimeException to support error codes et al.
Bugs: ACCUMULO-2497
https://issues.apache.org/jira/browse/ACCUMULO-2497
Repository: accumulo
Description
-------
To help in testing, this commit adds an InstanceFactory interface with some
implementations.
To avoid changing the public API, some classes are in o.a.a.core.client.impl.
Diffs (updated)
-----
core/pom.xml d56ca2c
core/src/main/java/org/apache/accumulo/core/client/impl/InstanceFactory.java
PRE-CREATION
core/src/main/java/org/apache/accumulo/core/client/impl/ZooKeeperInstanceFactory.java
PRE-CREATION
core/src/test/java/org/apache/accumulo/core/client/impl/ZooKeeperInstanceFactoryTest.java
PRE-CREATION
pom.xml f06380e
server/base/src/main/java/org/apache/accumulo/server/client/HdfsZooInstanceFactory.java
PRE-CREATION
server/base/src/test/java/org/apache/accumulo/server/client/HdfsZooInstanceFactoryTest.java
PRE-CREATION
Diff: https://reviews.apache.org/r/19409/diff/
Testing
-------
Unit tests pass.
Thanks,
Bill Havanki
