----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/19546/#review38173 -----------------------------------------------------------
Can you include a functional test that replicates the catastrophic failure that prompted ACCUMULO-2520 to verify that this change stops it? src/server/src/main/java/org/apache/accumulo/server/gc/SimpleGarbageCollector.java <https://reviews.apache.org/r/19546/#comment70150> nit: would you mind including {} for the if block? src/server/src/main/java/org/apache/accumulo/server/gc/SimpleGarbageCollector.java <https://reviews.apache.org/r/19546/#comment70151> nit: would you mind including {} for the if block? src/server/src/test/java/org/apache/accumulo/server/gc/SimpleGarbageCollectorTest.java <https://reviews.apache.org/r/19546/#comment70149> Please remove empty javadoc blocks Once this is forward ported to 1.6.0-SNAP, will it have to switch to absolute paths? both absolute and relative? - Sean Busbey On March 21, 2014, 7:27 p.m., kturner wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/19546/ > ----------------------------------------------------------- > > (Updated March 21, 2014, 7:27 p.m.) > > > Review request for accumulo. > > > Bugs: ACCUMULO-2520 > https://issues.apache.org/jira/browse/ACCUMULO-2520 > > > Repository: accumulo > > > Description > ------- > > This change should make the GC more robust against the case of it deleting > things it should not. A concern with this change is that may make the GC > fail in a situation where it should not, which could cause hdfs to fill. > > > Diffs > ----- > > > src/server/src/main/java/org/apache/accumulo/server/gc/SimpleGarbageCollector.java > 22c3c0e > > src/server/src/test/java/org/apache/accumulo/server/gc/SimpleGarbageCollectorTest.java > PRE-CREATION > > src/server/src/test/java/org/apache/accumulo/server/gc/TestConfirmDeletes.java > be444dd > > Diff: https://reviews.apache.org/r/19546/diff/ > > > Testing > ------- > > Added unit test > Ran 1.4.5-SNAPSHOT and verified GC worked and deleted an orphaned file > > > Thanks, > > kturner > >
