----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/19546/#review38227 -----------------------------------------------------------
src/server/src/main/java/org/apache/accumulo/server/gc/SimpleGarbageCollector.java <https://reviews.apache.org/r/19546/#comment70267> Not an issue, but if we have lots of places that use functions like these, it might be worth a follow on ticket to switch to Guava's Verify class. test/system/auto/simple/gc.py <https://reviews.apache.org/r/19546/#comment70257> Is it possible for the GC to delete all the files in HDFS under ACCUMULO-2520, but still have this verification call pass? e.g. if all the table entries fit in memory? - Sean Busbey On March 21, 2014, 10:34 p.m., kturner wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/19546/ > ----------------------------------------------------------- > > (Updated March 21, 2014, 10:34 p.m.) > > > Review request for accumulo. > > > Bugs: ACCUMULO-2520 > https://issues.apache.org/jira/browse/ACCUMULO-2520 > > > Repository: accumulo > > > Description > ------- > > This change should make the GC more robust against the case of it deleting > things it should not. A concern with this change is that may make the GC > fail in a situation where it should not, which could cause hdfs to fill. > > > Diffs > ----- > > > src/server/src/main/java/org/apache/accumulo/server/gc/SimpleGarbageCollector.java > 22c3c0e > > src/server/src/main/java/org/apache/accumulo/server/test/GCLotsOfCandidatesTest.java > 722fd1a > > src/server/src/test/java/org/apache/accumulo/server/gc/SimpleGarbageCollectorTest.java > PRE-CREATION > > src/server/src/test/java/org/apache/accumulo/server/gc/TestConfirmDeletes.java > be444dd > test/system/auto/simple/gc.py 4697246 > > Diff: https://reviews.apache.org/r/19546/diff/ > > > Testing > ------- > > Added unit test > Ran 1.4.5-SNAPSHOT and verified GC worked and deleted an orphaned file > > > Thanks, > > kturner > >
