-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/19546/
-----------------------------------------------------------
(Updated March 21, 2014, 10:34 p.m.)
Review request for accumulo.
Changes
-------
Updated gc functional test to trigger this issue.
Removed empty comment and added {} for if stmt
Bugs: ACCUMULO-2520
https://issues.apache.org/jira/browse/ACCUMULO-2520
Repository: accumulo
Description
-------
This change should make the GC more robust against the case of it deleting
things it should not. A concern with this change is that may make the GC fail
in a situation where it should not, which could cause hdfs to fill.
Diffs (updated)
-----
src/server/src/main/java/org/apache/accumulo/server/gc/SimpleGarbageCollector.java
22c3c0e
src/server/src/main/java/org/apache/accumulo/server/test/GCLotsOfCandidatesTest.java
722fd1a
src/server/src/test/java/org/apache/accumulo/server/gc/SimpleGarbageCollectorTest.java
PRE-CREATION
src/server/src/test/java/org/apache/accumulo/server/gc/TestConfirmDeletes.java
be444dd
test/system/auto/simple/gc.py 4697246
Diff: https://reviews.apache.org/r/19546/diff/
Testing
-------
Added unit test
Ran 1.4.5-SNAPSHOT and verified GC worked and deleted an orphaned file
Thanks,
kturner
