----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32986/ -----------------------------------------------------------
(Updated April 9, 2015, 3:57 p.m.) Review request for accumulo, Eric Newton and Josh Elser. Changes ------- This updated patch contains all the previous changes and also makes some modifications to the ShowTrace servlet and TraceDump to handle unrooted spans better (since they are now considered normal). I've kept all the sampling configuration because I think it could still be useful, even though just dropping 0ms spans is sufficient to get tracing down to a reasonable amount. Also TraceDump's main method appears to have been broken since 2012, so I tried to fix that. Repository: accumulo Description ------- Make sampling of traces configurable; clean up and standardize config parameters; update documentation Diffs (updated) ----- core/src/main/java/org/apache/accumulo/core/conf/Property.java 9dceb1e core/src/main/java/org/apache/accumulo/core/trace/DistributedTrace.java c5b6eac core/src/main/java/org/apache/accumulo/core/trace/ProbabilitySampler.java PRE-CREATION docs/src/main/asciidoc/chapters/administration.txt 0382934 server/gc/src/main/java/org/apache/accumulo/gc/SimpleGarbageCollector.java 04f21a1 server/master/src/main/java/org/apache/accumulo/master/replication/ReplicationDriver.java 63c6b20 server/monitor/src/main/java/org/apache/accumulo/monitor/servlets/trace/ShowTrace.java 4e05b89 server/tracer/src/main/java/org/apache/accumulo/tracer/AsyncSpanReceiver.java dbcb335 server/tracer/src/main/java/org/apache/accumulo/tracer/TraceDump.java e4eb70e server/tracer/src/main/java/org/apache/accumulo/tracer/TraceTableStats.java PRE-CREATION server/tserver/src/main/java/org/apache/accumulo/tserver/replication/AccumuloReplicaSystem.java cb8ae13 server/tserver/src/main/java/org/apache/accumulo/tserver/tablet/MinorCompactionTask.java 0f6a98d server/tserver/src/main/java/org/apache/accumulo/tserver/tablet/Tablet.java 43bd9d9 Diff: https://reviews.apache.org/r/32986/diff/ Testing ------- Thanks, Billie Rinaldi
