----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32986/#review79519 -----------------------------------------------------------
Ship it! LGTM core/src/main/java/org/apache/accumulo/core/trace/ProbabilitySampler.java <https://reviews.apache.org/r/32986/#comment128923> Some javadoc would be nice. server/tracer/src/main/java/org/apache/accumulo/tracer/TraceTableStats.java <https://reviews.apache.org/r/32986/#comment128925> hdfs and accumulo SpanTypeCount should be static final - Josh Elser On April 9, 2015, 3:57 p.m., Billie Rinaldi wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/32986/ > ----------------------------------------------------------- > > (Updated April 9, 2015, 3:57 p.m.) > > > Review request for accumulo, Eric Newton and Josh Elser. > > > Repository: accumulo > > > Description > ------- > > Make sampling of traces configurable; clean up and standardize config > parameters; update documentation > > > Diffs > ----- > > core/src/main/java/org/apache/accumulo/core/conf/Property.java 9dceb1e > core/src/main/java/org/apache/accumulo/core/trace/DistributedTrace.java > c5b6eac > core/src/main/java/org/apache/accumulo/core/trace/ProbabilitySampler.java > PRE-CREATION > docs/src/main/asciidoc/chapters/administration.txt 0382934 > server/gc/src/main/java/org/apache/accumulo/gc/SimpleGarbageCollector.java > 04f21a1 > > server/master/src/main/java/org/apache/accumulo/master/replication/ReplicationDriver.java > 63c6b20 > > server/monitor/src/main/java/org/apache/accumulo/monitor/servlets/trace/ShowTrace.java > 4e05b89 > > server/tracer/src/main/java/org/apache/accumulo/tracer/AsyncSpanReceiver.java > dbcb335 > server/tracer/src/main/java/org/apache/accumulo/tracer/TraceDump.java > e4eb70e > server/tracer/src/main/java/org/apache/accumulo/tracer/TraceTableStats.java > PRE-CREATION > > server/tserver/src/main/java/org/apache/accumulo/tserver/replication/AccumuloReplicaSystem.java > cb8ae13 > > server/tserver/src/main/java/org/apache/accumulo/tserver/tablet/MinorCompactionTask.java > 0f6a98d > server/tserver/src/main/java/org/apache/accumulo/tserver/tablet/Tablet.java > 43bd9d9 > > Diff: https://reviews.apache.org/r/32986/diff/ > > > Testing > ------- > > > Thanks, > > Billie Rinaldi > >
