I am going to experiment with leaving out the sampling and only dropping 0ms spans to see if that is a sufficient solution. Feel free to hold off on further review until I post the results.
On Wed, Apr 8, 2015 at 8:00 PM, Mike Drob <[email protected]> wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/32986/#review79472 > ----------------------------------------------------------- > > > > core/src/main/java/org/apache/accumulo/core/conf/Property.java > <https://reviews.apache.org/r/32986/#comment128875> > > If this property name changes, should we provide some level of support > for the old name? > > > - Mike Drob > > > On April 8, 2015, 7:41 p.m., Billie Rinaldi wrote: > > > > ----------------------------------------------------------- > > This is an automatically generated e-mail. To reply, visit: > > https://reviews.apache.org/r/32986/ > > ----------------------------------------------------------- > > > > (Updated April 8, 2015, 7:41 p.m.) > > > > > > Review request for accumulo, Eric Newton and Josh Elser. > > > > > > Repository: accumulo > > > > > > Description > > ------- > > > > Make sampling of traces configurable; clean up and standardize config > parameters; update documentation > > > > > > Diffs > > ----- > > > > core/src/main/java/org/apache/accumulo/core/conf/Property.java 9dceb1e > > > core/src/main/java/org/apache/accumulo/core/trace/DistributedTrace.java > c5b6eac > > > core/src/main/java/org/apache/accumulo/core/trace/ProbabilitySampler.java > PRE-CREATION > > docs/src/main/asciidoc/chapters/administration.txt 0382934 > > > server/gc/src/main/java/org/apache/accumulo/gc/SimpleGarbageCollector.java > 04f21a1 > > > > server/master/src/main/java/org/apache/accumulo/master/replication/ReplicationDriver.java > 63c6b20 > > > server/tracer/src/main/java/org/apache/accumulo/tracer/AsyncSpanReceiver.java > dbcb335 > > > server/tracer/src/main/java/org/apache/accumulo/tracer/TraceTableStats.java > PRE-CREATION > > > > server/tserver/src/main/java/org/apache/accumulo/tserver/replication/AccumuloReplicaSystem.java > cb8ae13 > > > > server/tserver/src/main/java/org/apache/accumulo/tserver/tablet/MinorCompactionTask.java > 0f6a98d > > > server/tserver/src/main/java/org/apache/accumulo/tserver/tablet/Tablet.java > 43bd9d9 > > > > Diff: https://reviews.apache.org/r/32986/diff/ > > > > > > Testing > > ------- > > > > > > Thanks, > > > > Billie Rinaldi > > > > > >
