Github user ivakegg commented on a diff in the pull request:
https://github.com/apache/accumulo/pull/134#discussion_r78074780
--- Diff:
core/src/main/java/org/apache/accumulo/core/file/rfile/bcfile/BCFile.java ---
@@ -672,11 +674,23 @@ public BlockRegion getBlockRegion() {
}
public void finish() throws IOException {
- try {
- in.close();
- } finally {
- compressAlgo.returnDecompressor(decompressor);
- decompressor = null;
+ if (!closed) {
--- End diff --
In general synchronizing on a monitor is significantly slower than checking
a boolean. However since the close method is invoked in general only once on
each instance, I can see the benefit of avoiding the initial check. As Josh
pointed out, closes are much less frequent and hence the performance impact is
minimal. I will take it out however.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
