Github user keith-turner commented on a diff in the pull request:

    https://github.com/apache/accumulo/pull/168#discussion_r83634597
  
    --- Diff: core/src/main/java/org/apache/accumulo/core/file/rfile/RFile.java 
---
    @@ -374,7 +380,42 @@ public void flushIfNeeded() throws IOException {
         }
       }
     
    -  private static class LocalityGroupWriter {
    +  private static class VisibilityHistogramLocalityGroupWriter {
    +    private final HashMap<Text,AtomicLong> histogram;
    +    private final LocalityGroupWriter lgr;
    +
    +    private ThreadLocal<Text> buffer = new ThreadLocal<Text>() {
    +      @Override public Text initialValue() {
    +        return new Text();
    +      }
    +    };
    +
    +    public VisibilityHistogramLocalityGroupWriter(LocalityGroupWriter lgr) 
{
    +      this.lgr = lgr;
    +      this.histogram = new HashMap<>(); 
    +    }
    +
    +    public void append(Key key, Value value) throws IOException {
    +      Text _text = buffer.get();
    +      key.getColumnFamily(_text);
    --- End diff --
    
    get the family?  Is this duplicate code?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Reply via email to