Github user ctubbsii commented on a diff in the pull request:
https://github.com/apache/accumulo/pull/220#discussion_r102623116
--- Diff:
server/master/src/main/java/org/apache/accumulo/master/replication/RemoveCompleteReplicationRecords.java
---
@@ -216,4 +220,13 @@ protected long removeRowIfNecessary(BatchWriter bw,
SortedMap<Key,Value> columns
return recordsRemoved;
}
+
+ /*
+ * Metrics calls snapshot. Largest time stamp will be found for each
snapshot then reset.
+ */
+ private void collectLatency(Long createdTime) {
+ long latency = System.currentTimeMillis() - createdTime;
--- End diff --
`System.currentTimeMillis()` is unreliable for tracking time differences,
and this subtraction could even be negative. Use `System.nanoTime()` for time
differences/durations. The difference is guaranteed to be positive.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
