Github user keith-turner commented on a diff in the pull request:
https://github.com/apache/accumulo/pull/220#discussion_r102770533
--- Diff:
server/master/src/main/java/org/apache/accumulo/master/replication/RemoveCompleteReplicationRecords.java
---
@@ -216,4 +220,13 @@ protected long removeRowIfNecessary(BatchWriter bw,
SortedMap<Key,Value> columns
return recordsRemoved;
}
+
+ /*
+ * Metrics calls snapshot. Largest time stamp will be found for each
snapshot then reset.
+ */
+ private void collectLatency(Long createdTime) {
+ long latency = System.currentTimeMillis() - createdTime;
--- End diff --
I am not sure, but I think this createdTime may come from a persisted
source? @joshelser is that right? If its coming from a persisted source,
then it could have come from another process. In that case using
`System.currentTimeMillis()` is reasonable. `System.nanoTime()` can reliably
compute time deltas within a process.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
