Github user milleruntime commented on a diff in the pull request:

    https://github.com/apache/accumulo/pull/289#discussion_r132199113
  
    --- Diff: 
server/monitor/src/main/java/org/apache/accumulo/monitor/rest/trace/TracesResource.java
 ---
    @@ -77,12 +81,12 @@
        * Generates a trace summary
        *
        * @param minutes
    -   *          Range of minutes to filter traces
    +   *          Range of minutes to filter traces Min of 0 minutes, Max of 
30 days
        * @return Trace summary in specified range
        */
       @Path("summary/{minutes}")
       @GET
    -  public RecentTracesList getTraces(@DefaultValue("10") 
@PathParam("minutes") int minutes) throws Exception {
    +  public RecentTracesList getTraces(@DefaultValue("10") 
@PathParam("minutes") @Min(0) @Max(2592000) int minutes) throws Exception {
    --- End diff --
    
    Wouldn't defaulting to ignored annotation introduce a vulnerability in the 
validation? Say if an admin doesn't setup the monitor correctly or disables the 
auto-discovery.  I am wondering why we would ever want to disable the 
validation and can we prevent it from being disabled?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Reply via email to