Github user clebertsuconic commented on a diff in the pull request:
https://github.com/apache/activemq-artemis/pull/740#discussion_r77178512
--- Diff:
artemis-protocols/artemis-openwire-protocol/src/main/java/org/apache/activemq/artemis/core/protocol/openwire/OpenWireConnection.java
---
@@ -742,6 +756,25 @@ public void addConsumer(ConsumerInfo info) throws
Exception {
}
}
+ public void setConnectionEntry(ConnectionEntry connectionEntry) {
+ this.connectionEntry = connectionEntry;
+ }
+
+ public void setUpTtl(final long inactivityDuration, final long
inactivityDurationInitialDelay, final boolean useKeepAlive) {
+ this.useKeepAlive = useKeepAlive;
+ this.maxInactivityDuration = inactivityDuration;
+
+ protocolManager.getScheduledPool().schedule(new Runnable() {
--- End diff --
@gaohoward I guess this fix is not valid then. If you set the server to
send Pings to client faster than the client is configured you will later miss
another ping on the client.
this was a TODO before and I thought you were fixing it. The server must
ping at a sustained rate regardless of what the client sends.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
