Github user gaohoward commented on a diff in the pull request:
https://github.com/apache/activemq-artemis/pull/740#discussion_r77281820
--- Diff:
artemis-protocols/artemis-openwire-protocol/src/main/java/org/apache/activemq/artemis/core/protocol/openwire/OpenWireConnection.java
---
@@ -742,6 +756,25 @@ public void addConsumer(ConsumerInfo info) throws
Exception {
}
}
+ public void setConnectionEntry(ConnectionEntry connectionEntry) {
+ this.connectionEntry = connectionEntry;
+ }
+
+ public void setUpTtl(final long inactivityDuration, final long
inactivityDurationInitialDelay, final boolean useKeepAlive) {
+ this.useKeepAlive = useKeepAlive;
+ this.maxInactivityDuration = inactivityDuration;
+
+ protocolManager.getScheduledPool().schedule(new Runnable() {
--- End diff --
@clebertsuconic I don't understand. I thought it should be faster. For
example if client sets the inactivityDuration (ttl) to be 10 src the server
will sends a ping at least 5 sec (about half of the ttl )back to client
(current impl). If it sends a ping for every 10 sec, there is a high chance
client missing a ping and time out the connection.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
