Github user michaelandrepearce commented on a diff in the pull request:

    https://github.com/apache/activemq-artemis/pull/1443#discussion_r131530398
  
    --- Diff: 
artemis-server/src/main/java/org/apache/activemq/artemis/core/config/impl/ConfigurationImpl.java
 ---
    @@ -2064,6 +2072,53 @@ public Configuration 
setNetworkCheckPing6Command(String command) {
           return this;
        }
     
    +   @Override
    +   public boolean isAnalyzeCritical() {
    +      return analyzeCritical;
    +   }
    +
    +   @Override
    +   public Configuration setAnalyzeCritical(boolean analyzeCritical) {
    +      this.analyzeCritical = analyzeCritical;
    +      return this;
    +   }
    +
    +   @Override
    +   public long getAnalyzeCriticalTimeout() {
    +      return analyzeCriticalTimeout;
    +   }
    +
    +   @Override
    +   public Configuration setAnalyzeCriticalTimeout(long timeout) {
    +      this.analyzeCriticalTimeout = timeout;
    +      return this;
    +   }
    +
    +   @Override
    +   public long getAnalyzeCriticalCheckPeriod() {
    +      if (analyzeCriticalCheckPeriod == 
ActiveMQDefaultConfiguration.getAnalyzeCriticalCheckPeriod()) {
    --- End diff --
    
    how would you differentiate between it being the default and someone 
actually have set it, should this defaulting not occur in config/broker.xml 
reading where if null then analyzeCriticalCheckPeriod is defaulted to half 
timeout?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Reply via email to