Github user michaelandrepearce commented on a diff in the pull request:

    https://github.com/apache/activemq-artemis/pull/1443#discussion_r131530423
  
    --- Diff: 
artemis-server/src/main/java/org/apache/activemq/artemis/core/deployers/impl/FileConfigurationParser.java
 ---
    @@ -608,6 +608,14 @@ public void parseMainConfig(final Element e, final 
Configuration config) throws
     
           config.setNetworkCheckPingCommand(getString(e, 
"network-check-ping-command", config.getNetworkCheckPingCommand(), 
Validators.NO_CHECK));
     
    +      config.setAnalyzeCritical(getBoolean(e, "analyze-critical", 
config.isAnalyzeCritical()));
    +
    +      config.setAnalyzeCriticalTimeout(getLong(e, 
"analyze-critical-timeout", config.getAnalyzeCriticalTimeout(), 
Validators.GE_ZERO));
    +
    +      config.setAnalyzeCriticalCheckPeriod(getLong(e, 
"analyze-critical-check-period", config.getAnalyzeCriticalCheckPeriod(), 
Validators.GE_ZERO));
    --- End diff --
    
    as per other review comment should the default not be half the timeout  if 
it is not set, not some arbitarty number which then forces the section of code 
later.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Reply via email to