Github user michaelandrepearce commented on a diff in the pull request:

    https://github.com/apache/activemq-artemis/pull/1443#discussion_r131530870
  
    --- Diff: 
artemis-server/src/main/java/org/apache/activemq/artemis/core/server/impl/ActiveMQServerImpl.java
 ---
    @@ -477,12 +484,44 @@ public final synchronized void start() throws 
Exception {
           }
        }
     
    +   @Override
    +   public CriticalAnalyzer getCriticalAnalyzer() {
    +      return this.analyzer;
    +   }
    +
        private void internalStart() throws Exception {
           if (state != SERVER_STATE.STOPPED) {
              logger.debug("Server already started!");
              return;
           }
     
    +      if (!configuration.isAnalyzeCritical()) {
    +         this.analyzer = new EmptyCriticalAnalyzer();
    +      }
    +
    +      /** Calling this for cases where the server was stopped and now is 
being restarted... failback, etc...*/
    +      this.analyzer.clear();
    +
    +      
this.getCriticalAnalyzer().setCheckTime(configuration.getAnalyzeCriticalTimeout()).setTimeout(configuration.getAnalyzeCriticalTimeout());
    --- End diff --
    
    again why not do this in the constructor?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Reply via email to