Github user gemmellr commented on a diff in the pull request:
https://github.com/apache/activemq-artemis/pull/1601#discussion_r145907083
--- Diff:
artemis-protocols/artemis-amqp-protocol/src/main/java/org/apache/activemq/artemis/protocol/amqp/proton/handler/ProtonHandler.java
---
@@ -443,7 +445,9 @@ private void dispatch() {
inDispatch = true;
while ((ev = collector.peek()) != null) {
for (EventHandler h : handlers) {
- if (log.isTraceEnabled()) {
+ if (PN_TRACE_FRM) {
+ log.info("Handling " + ev + " towards " + h);
--- End diff --
This also doesn't feel like it should be tied to having proton trace its
frames to me. Given the existing trace logging I wouldn't do this.
---