Github user gemmellr commented on a diff in the pull request:
https://github.com/apache/activemq-artemis/pull/1601#discussion_r145910546
--- Diff:
artemis-protocols/artemis-amqp-protocol/src/main/java/org/apache/activemq/artemis/protocol/amqp/proton/AMQPConnectionContext.java
---
@@ -143,13 +144,26 @@ public SASLResult getSASLResult() {
}
public void inputBuffer(ByteBuf buffer) {
- if (log.isTraceEnabled()) {
- ByteUtil.debugFrame(log, "Buffer Received ", buffer);
+ if (PN_TRACE_FRM) {
--- End diff --
I wouldn't personally tie these things together, to me they are separate
and just because I am asking proton to trace frames doesn't mean I want all the
bytes logged. I do the former often enough, but only very rarely do the latter.
When I do the latter its sometimes by using config toggle to activate
adding Nettys own byte logging debug LoggingHandler, though e.g for Qpid JMS we
do also have specific toggles to activate something more like this.
---
