Github user gemmellr commented on a diff in the pull request: https://github.com/apache/activemq-artemis/pull/1601#discussion_r145959626 --- Diff: artemis-protocols/artemis-amqp-protocol/src/main/java/org/apache/activemq/artemis/protocol/amqp/proton/handler/ProtonHandler.java --- @@ -443,7 +445,9 @@ private void dispatch() { inDispatch = true; while ((ev = collector.peek()) != null) { for (EventHandler h : handlers) { - if (log.isTraceEnabled()) { + if (PN_TRACE_FRM) { + log.info("Handling " + ev + " towards " + h); --- End diff -- I'm not saying you don't need it, or that they often wont be combined eventually, but I rarely ever want to turn that logging on at precisely the same time as I might turn the frame logging on. They don't even go to the same place, so I really feel they are separate and should have their own control toggles as they do currently. I also wouldn't generally use another projects magic toggle to control behaviour in this one.
---