Github user jdanekrh commented on a diff in the pull request:
https://github.com/apache/activemq-artemis/pull/1684#discussion_r154599253
--- Diff:
artemis-protocols/artemis-amqp-protocol/src/main/java/org/apache/activemq/artemis/protocol/amqp/converter/CoreAmqpConverter.java
---
@@ -95,7 +95,7 @@
public class CoreAmqpConverter {
private static Logger logger =
Logger.getLogger(CoreAmqpConverter.class);
-
+ public static final String INTERNAL_HEADER = "__HDR_";
--- End diff --
I am thinking whether this variable should have a broader scope and be
consistently used instead of the string constant. I know of at least one other
such place, the `__HDR_` stripping code in
https://github.com/apache/activemq-artemis/pull/1320/files.
---
