Github user michaelandrepearce commented on the issue:

    https://github.com/apache/activemq-artemis/pull/1684
  
    On that note, going through the OpenWireConverter that currently converts 
OpenWire to Core on produce, there is many places where its not setting the 
correct matching properties (or methods) on core because it has them hardcoded 
as string, instead of using the constants from Message (in core).
    
    Example
    
    ```
          String groupId = messageSend.getGroupID();
          if (groupId != null) {
             coreMessage.putStringProperty(AMQ_MSG_GROUP_ID, groupId);
          }
    ```
    
    Here the property being set is "__HDR_GROUP_ID" where as in core Message if 
using the constants from there, then actually what should be set is
    
    ```
          String groupId = messageSend.getGroupID();
          if (groupId != null) {
             
coreMessage.putStringProperty(org.apache.activemq.artemis.api.core.Message.HDR_GROUP_ID,
 SimpleString.toSimpleString(groupId));
          }
    ```
    
    so that it actually sets the correct property than then is handled by other 
converters properly. (its seems this is quite numerous in the converter, just 
briefly going through it. )
    
    (please be aware this are of code I'm less familiar in artemis with but a 
brief look through, i see such oddities)


---

Reply via email to